Skip to content

Fix: Switch to lowercase for findAncestor type (fix #115) #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 6 commits into from
Oct 23, 2025
Merged

Fix: Switch to lowercase for findAncestor type (fix #115) #116

oliverfoster merged 6 commits into from
Oct 23, 2025

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Oct 13, 2025

fixes #115

Fix

  • Changed to lowercase type when using findAncestor from core AdaptModel

@oliverfoster oliverfoster self-assigned this Oct 13, 2025
@swashbuck swashbuck changed the title Fix: Switch to lowercase for findAncestor type Fix: Switch to lowercase for findAncestor type (fix #115) Oct 22, 2025
swashbuck
swashbuck reviewed Oct 22, 2025
View reviewed changes
oliverfoster and others added 4 commits October 22, 2025 23:17
swashbuck
swashbuck approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit d9bce3a into master Oct 23, 2025
@oliverfoster oliverfoster deleted the issue/115 branch October 23, 2025 15:12
github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
@semantic-release-bot
Chore(release): 3.10.1 [skip ci]
41cb29f 
## [3.10.1](v3.10.0...v3.10.1) (2025-10-23)

### Fix

* Switch to lowercase singular for findAncestor type (fix #115) (#116) ([d9bce3a](d9bce3a)), closes [#115](#115) [#116](#116)
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

🎉 This PR is included in version 3.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uses deprecated findAncestor

3 participants

@oliverfoster @swashbuck