Skip to content

various improvements #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankrousseau merged 2 commits into from
Dec 11, 2024
Merged

various improvements #1601

frankrousseau merged 2 commits into from
Dec 11, 2024

Conversation

@EvanBldy
Copy link
Member

@EvanBldy EvanBldy commented Dec 11, 2024

Problem

  • Due to this PR (various improvements zou#895), page_size is changed with limit.
  • When uploading a movie preview a warning message always tells that there's a wrong number of frames in that movie preview.

Solution

  • The page_size query parameter for getEvents has been changed with a limit.
  • Fix frame calculation from the original movie (no need to add one frame in the calculation) + don't show this warning if there's no information about frame duration in that entity + fix locales

@frankrousseau frankrousseau merged commit 7070230 into cgwire:main Dec 11, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@frankrousseau frankrousseau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EvanBldy @frankrousseau