Skip to content

Conversation

@NicoPennec
Copy link
Member

Problem

  • Various cases of undefined values, caused by outdated IDs or data, can cause the Kitsu UI to become unresponsive.
  • The minimum password length in the password forms is set to 7 characters on Kitsu, but 8 characters in Zou.
  • Wrong unit in the production stats when displayed in hours (see Production Stats Mismatch Hours/Days #1906).
  • On a playlist of sequences, the UI fails on the Add Sequences action.
  • A translation is missing in the Type filter of the Notifications page.
  • When the API is slow to respond, you receive a completely blank page when opening Kitsu.
  • Some npm dependencies are outdated.

Solution

  • Fix edge cases of undefined value.
  • Fix the minimum password length in the password forms: reset, change, ...
  • Fix the time unit in the production stats when displayed in hours.
  • Fix the Add Sequences action for sequence playlists. Use the right array to load data.
  • Add missing i18n key for the Type filter of the Notifications page.
  • Improve the UX when starting Kitsu.
  • Bump npm dependencies.

@gitguardian
Copy link

gitguardian bot commented Nov 25, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password 8717d1b tests/unit/lib/auth.spec.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@NicoPennec NicoPennec force-pushed the main branch 2 times, most recently from 1f7f6fe to 0985b4f Compare November 25, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants