feat: enable all entities for schedule display #1004 #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2025
Contributor
|
Hello can remove the commit related to the deletion? The deletion should occur only after the rights validation. |
Author
Yes, I can move the cascade deletion to after rights validation, my apologies for the incorrect placement. I was having an error where a foreign key constraint was blocking deletion of task types, because of lingering scheduleItem records. I'll use the pre_delete hook for this instead. |
…eleted. Uses pre_delete hook to ensure deletion happens AFTER permission check.
The migration file was part of a different feature branch and was mistakenly included in the cascading deletion commit.
Author
|
@frankrousseau Okay, the cascading deletion occurs after permissions check now. Disregard the migration, that was from a different PR that I accidentally included. |
Contributor
|
Great thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is recreated from a previous because I had to change the head branch.
Problem
Closes #1003
Solution
Now all entity task types are sent to the frontend for display and possible filtering.
I should emphasize: BOTH THIS PR AND THE PR ON THE FRONTEND KITSU REPO (cgwire/kitsu#1924) MUST BE APPROVED FOR THIS FUNCTIONALITY TO WORK PROPERLY. Without the frontend changes, the necessary data is not displayed or available to filter properly.