Small changes to get eyre to build on Ubuntu 10.04#1
Open
dhruvbansal wants to merge 5 commits intocgyarvin:masterfrom
dhruvbansal:master
Open
Small changes to get eyre to build on Ubuntu 10.04#1dhruvbansal wants to merge 5 commits intocgyarvin:masterfrom dhruvbansal:master
dhruvbansal wants to merge 5 commits intocgyarvin:masterfrom
dhruvbansal:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get eyre to build for me on Ubuntu 10.04 so I made a few tweaks:
Makefilenow sets the default include directly based on the value ofOSstat. Code as written wasn't portable to Linux b/c of use ofst_mtimespecwhich is only defined on BSD. Used a macro that checks the value ofOSand appropriately uses eitherst_mtimespecorst_mtime.gitignoreEyre now builds and starts...and then segfaults immediately. But first things first -- I've got it running, yay!