Open
Conversation
|
Why this PR has never be merged ? It is relevant and well implemented with tests. |
Owner
Collaborator
|
@ch2877 My knowledge here is very limited. But looking at the code it does make sense and should not break anything else 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For some banks, such as BCV, not indicating anything in the Notification Instruction in combination with the Batch Booking value set to
trueis processed by the bank with a global debit notification without details.In result, the camt.053 file does not include the
EndToEndId.If we want to receive the details of all the transactions from our payment in the camt.053 file and at the same time have a single grouped entry on our account statement, our XML has to contain
CWDin the Notification Instruction.This pull request adds the Notification Instruction based on six-group implementation guideline1 and tests.
Usage
Notes
PmtInf/DbtrAcct/Tp/Codeat the same time. The library doesn't supportCodeat the moment so it shouldn't be an issueReferences
Footnotes
Implementation guideline: https://www.six-group.com/dam/download/banking-services/interbank-clearing/en/standardization/iso/swiss-recommendations/implementation-guidelines-ct.pdf#page=31 ↩
Swiss Business Rule: https://www.six-group.com/dam/download/banking-services/interbank-clearing/en/standardization/iso/swiss-recommendations/business-rules.pdf#page=48 ↩