Initialise J2KDecoder member variables#8
Open
lpartington wants to merge 2 commits intochafey:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoder member variables are not initialised, so the getXXX methods return essentially random values if decoding fails (the values are not entirely random in the WASM build - it appears that a J2KDecoder instance will sometimes be placed in the same location as a previous instance and will get whatever values that previous instance had, which can be very confusing).
Unfortunately the c++ test had to be modified as 'designated initializers' syntax is incompatible with a default constructor for FrameInfo. An alternative would be to initialize each member of FrameInfo in the J2KDecoder ctor but this seems a bit uglier to me.