Skip to content

Conversation

@chirino
Copy link
Contributor

@chirino chirino commented Sep 6, 2024

No description provided.

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Copy link

@jphastings jphastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read all the new Go code (there is extremely little!) and used this branch in a tool of my own that makes use of many of this library's features successfully.

FWIW, I'm happy this can be merged — is there anything else I can help with here @chai2010?

You can test this branch in your project by dropping the following in your go.mod file, and running go mod tidy:

replace github.com/chai2010/webp => github.com/chirino/webp webp-1.4.0

@chirino, on the off chance this does get merged, if you add "Closes #74 #41 #55 #61 #60" to your PR description it'll close the related issues & PRs.

@chirino chirino changed the title Update to webp 1.4.0 Update to webp 1.4.0 Closes #74 #41 #55 #61 #60 Dec 9, 2024
@seantiz
Copy link

seantiz commented Dec 20, 2024

replace github.com/chai2010/webp => github.com/chirino/webp webp-1.4.0

The replace syntax throws an error for me. Is this a version number?

@jphastings
Copy link

@seantiz its a branch name - do check out the go mod docs and see if I've made a mistake there! (I'm away from a computer for the next few weeks or I'd check myself!)

@andriamirul
Copy link

@jphastings Hi, any updates of when these fix will be released?

@jphastings
Copy link

@andriamirul You’d have to ask the owner of the repo. I think it’s abandoned 😔

@GabrielRabello
Copy link

@chai2010 Please approve this PR. It solves a lot of security vulnerability warnings.

@chai2010 chai2010 merged commit 76805d5 into chai2010:master Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants