Skip to content

feat(policy): allow empty kind in policy #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Piskoo
Copy link
Collaborator

@Piskoo Piskoo commented Aug 11, 2025

This PR adds material selector handler to policy devel eval. If no kind was specified in the policy then the policy will always be applied to the given material.

Closes #2337

Piskoo added 2 commits August 11, 2025 15:41
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo marked this pull request as ready for review August 11, 2025 14:13
@Piskoo Piskoo requested review from migmartri and jiparis August 11, 2025 14:13
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this behave when the policies have kinds? does it override it?

@migmartri
Copy link
Member

Can you rebase main please? I just merged your other change to run some tests

Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked this and it seems to work as expected

Piskoo and others added 3 commits August 11, 2025 17:36
Co-authored-by: Miguel Martinez Trivino <migmartri@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was quickly checking with @jiparis and thought that maybe we need to stop for a second and re-evaluate if we want this. Let's sync on this feature tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

policies eval, potential behavior change
3 participants