-
Notifications
You must be signed in to change notification settings - Fork 38
feat(policy): allow empty kind in policy #2343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this behave when the policies have kinds? does it override it?
Can you rebase main please? I just merged your other change to run some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checked this and it seems to work as expected
Co-authored-by: Miguel Martinez Trivino <migmartri@gmail.com> Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was quickly checking with @jiparis and thought that maybe we need to stop for a second and re-evaluate if we want this. Let's sync on this feature tomorrow
This PR adds material selector handler to policy devel eval. If no kind was specified in the policy then the policy will always be applied to the given material.
Closes #2337