Update Presence events and functions. New msglist command #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
can we move these commands to a separate folder similar to other plugins. its a fairly large chunk of isolated code |
Collaborator
|
Be sure to also put in checks for user allowing DMs for the messagelist. It would help prevent crashes and could possible keep the messages until the user switches the permissions for DMs for that server. It would also be beneficial if this is converted to a sqlite db instead of storing the data in memory just incase the bot crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the presence event code to properly detect user status changes. Msgs command will now send stored messages to users when their status changes to "online" or "idle". Currently, if a Msg is created while a user is already online/idle, it won't be sent until the status changes. Msglist command retrieves messages the caller has sent to the target.