Discussion: Should one use the 3rd party CarouselView or Xamarin Forms' implementation #33
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Xamarin.Forms" version="4.4.0.991220-pre3" targetFramework="net" /> | ||
| </packages> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Collections.ObjectModel; | ||
| using System.ComponentModel; | ||
| using System.Linq; | ||
| using System.Reflection; | ||
| using Xam.Plugin.TabView.Converters; | ||
| using Xamarin.Forms; | ||
|
|
||
|
|
@@ -18,13 +18,7 @@ public class PositionChangingEventArgs : EventArgs | |
| public int NewPosition { get; set; } | ||
| public int OldPosition { get; set; } | ||
| } | ||
|
|
||
| static class TabDefaults | ||
| { | ||
| public static readonly Color DefaultColor = Color.White; | ||
|
|
@@ -36,8 +30,9 @@ public class TabViewControl : ContentView | |
| { | ||
| private StackLayout _mainContainerSL; | ||
| private Grid _headerContainerGrid; | ||
| private CarouselView _carouselView; | ||
| private ScrollView _tabHeadersContainerSv; | ||
| private ConstructorInfo _positionChangedEventArgsInfo; | ||
|
|
||
| public event PositionChangingEventHandler PositionChanging; | ||
| public event PositionChangedEventHandler PositionChanged; | ||
|
|
@@ -124,10 +119,10 @@ private void _carouselView_PropertyChanged(object sender, PropertyChangedEventAr | |
| if (positionChangingArgs != null && positionChangingArgs.Canceled) | ||
| { | ||
| _supressCarouselViewPositionChangedEvent = true; | ||
| _carouselView.PositionChanged -= _carouselView_PositionSelected; | ||
| _carouselView.PropertyChanged -= _carouselView_PropertyChanged; | ||
| _carouselView.Position = SelectedTabIndex; | ||
| _carouselView.PositionChanged += _carouselView_PositionSelected; | ||
| _carouselView.PropertyChanged += _carouselView_PropertyChanged; | ||
| _supressCarouselViewPositionChangedEvent = false; | ||
| } | ||
|
|
@@ -158,18 +153,23 @@ private void Init() | |
| HorizontalOptions = LayoutOptions.FillAndExpand | ||
| }; | ||
|
|
||
| _carouselView = new CarouselView() | ||
| { | ||
| HorizontalOptions = LayoutOptions.FillAndExpand, | ||
| VerticalOptions = LayoutOptions.FillAndExpand, | ||
| HeightRequest = ContentHeight, | ||
| BindingContext = this, | ||
| ItemTemplate = new DataTemplate(() => | ||
| { | ||
| ContentView c = new ContentView(); | ||
| c.SetBinding(ContentView.ContentProperty, "Content"); | ||
| return c; | ||
| }) | ||
| }; | ||
| _positionChangedEventArgsInfo = typeof(PositionChangedEventArgs).GetTypeInfo().DeclaredConstructors.First(); | ||
|
|
||
| _carouselView.PropertyChanged += _carouselView_PropertyChanged; | ||
| _carouselView.PositionChanged += _carouselView_PositionSelected; | ||
|
|
||
| _mainContainerSL = new StackLayout | ||
| { | ||
|
|
@@ -199,11 +199,11 @@ protected override void OnBindingContextChanged() | |
| } | ||
| } | ||
|
|
||
| private void _carouselView_PositionSelected(object sender, PositionChangedEventArgs e) | ||
| { | ||
| if (_carouselView.Position != e.CurrentPosition || SelectedTabIndex != e.CurrentPosition) | ||
| { | ||
| SetPosition(e.CurrentPosition); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -291,7 +291,7 @@ private void AddTabToView(TabItem tab) | |
| }; | ||
| headerItemSL.GestureRecognizers.Add(tapRecognizer); | ||
| _headerContainerGrid.Children.Add(headerItemSL, _headerContainerGrid.ColumnDefinitions.Count - 1, 0); | ||
| _carouselView.ItemsSource = ItemSource; | ||
| } | ||
|
|
||
| #region IsSwipingEnabled | ||
|
|
@@ -548,9 +548,9 @@ public void SetPosition(int position, bool initialRun = false) | |
| { | ||
| if (_carouselView.Position != position || initialRun) | ||
| { | ||
| _carouselView.PositionChanged -= _carouselView_PositionSelected; | ||
| _carouselView.Position = position; | ||
| _carouselView.PositionChanged += _carouselView_PositionSelected; | ||
| } | ||
| if (oldPosition != position) | ||
| { | ||
|
|
@@ -565,11 +565,9 @@ public void SetPosition(int position, bool initialRun = false) | |
| } | ||
| } | ||
|
|
||
| var positionChangedArgs = _positionChangedEventArgsInfo.Invoke( | ||
|
Author
There was a problem hiding this comment. PositionChangedEventArgs has an internal constructor so this is a "hacky" way to call it. There was a problem hiding this comment. @kapseliboi you do not have to remove the PositionChangedEventArgs definition in the Xam.Plugin.TabView namespace nor to use the internal constructor: Just use the fully qualified name "Xamarin.Forms.PositionChangedEventArgs" in the _carouselView_PositionSelected method parameter and continue using Xam.Plugin.TabView.PositionChangedEventArgs for the rest (fully qualified name is not required for this one i think) That would prevent the API breakage |
||
| new object[] { oldPosition, SelectedTabIndex }) as PositionChangedEventArgs; | ||
|
|
||
| OnPositionChanged(positionChangedArgs); | ||
| } | ||
|
|
||
|
|
@@ -623,7 +621,8 @@ public void RemoveTab(int position = -1) | |
| _headerContainerGrid.Children.RemoveAt(_headerContainerGrid.Children.Count - 1); | ||
| _headerContainerGrid.ColumnDefinitions.Remove(_headerContainerGrid.ColumnDefinitions.Last()); | ||
| } | ||
|
|
||
| _carouselView.ItemsSource = ItemSource; | ||
| SelectedTabIndex = position >= 0 && position < ItemSource.Count ? position : ItemSource.Count - 1; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to build the sample app without this line.