Add smoke test to PRs #3151
Draft
Add smoke test to PRs #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add smoke test that starts Augur using the Docker compose file with the images that were just built. - Update the backend CLI to accept the `AUGUR_DISABLE_COLLECTION` environment variable. Signed-off-by: John Strunk <jstrunk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUGUR_DISABLE_COLLECTIONenvironment variable.Notes for Reviewers
I had to disable the collection since I'm not aware of a way to securely use a GH or GL token to actually test collection. Repo secrets aren't available to PRs from forked repos, and even if they were, it'd be trivial for a user to extract them w/ a malicious PR.