Skip to content

Conversation

@alberefe
Copy link
Contributor

Implement credential management system with Hashicorp Vault integration. This provides automated secrets retrieval.

This relieves the user from hardcoding credentials in files and also automates the retrieval of api keys from pools in an automated way, optimizing speed when the program needs to rotate through several api keys or credentials to access different services in a row.

It follows the same idea of Bitwarden Manager class, but using other service.

The following are the contents of the PR:

Add Hashicorp manager (hc_manager.py)
Custom exception handling
Test coverage for the class functionality
Instructions of use

@alberefe
Copy link
Contributor Author

alberefe commented Nov 21, 2025

Missed some things that are fixed now.

Poetry.lock was rebuilt, changelog included.

@jjmerchante @sduenas (mentioning you both cause I can't ask for reviews through the UI and I don't know if this got anywhere)

(sorry for delay was a crazy week)

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR looks ok but I'm suggesting some minor changes. Nothing related with how the code works.

@alberefe alberefe force-pushed the feature/hc_manager branch 2 times, most recently from 4f49daa to 3c9cc93 Compare December 1, 2025 20:44
@alberefe
Copy link
Contributor Author

alberefe commented Dec 1, 2025

The changes have been done. I can't find a way to get that poetry.lock conflict out of the way. I have remade the poetry.lock file several times and tried this:

rm poetry.lock
poetry update
git add poetry.lock
git commit --amend

That apparently worked in the other PR but doesn't here?

@alberefe alberefe requested a review from sduenas January 15, 2026 14:10
@sduenas
Copy link
Member

sduenas commented Jan 15, 2026

@alberefe can you solve the problems with the poetry.lock, please?

@alberefe alberefe force-pushed the feature/hc_manager branch 2 times, most recently from 35bf2b8 to 14358a5 Compare January 19, 2026 10:03
@alberefe
Copy link
Contributor Author

There is a problem with one of the unresolved conversations, with dependencies and CI.

@alberefe alberefe force-pushed the feature/hc_manager branch 4 times, most recently from 2ce7fe0 to a10c39e Compare January 25, 2026 13:54
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
@alberefe
Copy link
Contributor Author

Okay so everything should be up!

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me but you are using Poetry 1.8 while we're using 2.1. Please install that version to generate the right poetry.lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants