-
Notifications
You must be signed in to change notification settings - Fork 428
Convert testReleaseHelp
script to bash
#27320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Subhramit Basu <subhramit.bb@live.in>
Hi, I am new to Chapel. Thanks! |
Hi @subhramit, welcome to the Chapel community! I am happy to review this and help get it ready to merge. Just letting you know that I'll review this today and if no changes are needed get it ready to merge. We are getting very close to a release (code freeze is June 4th) so this may not make the 2.5 release, since its a critical script in our testing infrastructure. |
Thank you!
Sure, makes perfect sense, Jade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! I am testing it locally now, but assuming that comes back clean everything is ready to merge (either now or post-release).
Please see the one comment I had, its a small thing but could make this script a little more portable
Signed-off-by: Subhramit Basu <subhramit.bb@live.in>
Learnt something new - thank you for the comment :) |
This PR is good to go, but given its significance to the CI I am going to hold off merging it until after the release. But I have flagged it to be merged immediately post release. Thanks so much for contributing this! |
Closes #26561
Closes #14133 (excluding the additional Travis CI check request)
Port
testReleaseHelp
to bash.Test run logs (using
cmake-3.25.1
):Log
(The protobuf error is unrelated to the changes)