Skip to content

fix(next-drupal): undefined is not serializable #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(next-drupal): undefined is not serializable #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46067dd
fix(next-drupal): undefined is not serializable
yobottehg Jan 20, 2025
e0df32a
fix(next-drupal): update snapshot
yobottehg Jan 20, 2025
dd9ba80
fix(next-drupal): update snapshot
yobottehg Jan 20, 2025
c4f77a8
Merge branch 'main' into seralize_793
yobottehg Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next-drupal/src/menu-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class DrupalMenuTree<

this.push({
...menuItem,
items: subtree.length ? subtree : undefined,
items: subtree.length ? subtree : null,
})
}
}
Expand Down
10 changes: 5 additions & 5 deletions packages/next-drupal/tests/DrupalMenuTree/drupal-menu-tree.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,33 +67,33 @@ DrupalMenuTree [
"items": DrupalMenuTree [
{
"id": "7",
"items": undefined,
"items": null,
"parent": "4",
},
],
"parent": "1",
},
{
"id": "5",
"items": undefined,
"items": null,
"parent": "1",
},
{
"id": "6",
"items": undefined,
"items": null,
"parent": "1",
},
],
"parent": "",
},
{
"id": "2",
"items": undefined,
"items": null,
"parent": "",
},
{
"id": "3",
"items": undefined,
"items": null,
"parent": "",
},
]
Expand Down
12 changes: 6 additions & 6 deletions packages/next-drupal/tests/NextDrupal/__snapshots__/resource-methods.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ exports[`getMenu() fetches menu items for a menu 1`] = `
"enabled": true,
"expanded": false,
"id": "standard.front_page",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": [],
"options": [],
Expand All @@ -513,7 +513,7 @@ exports[`getMenu() fetches menu items for a menu 1`] = `
"enabled": true,
"expanded": false,
"id": "views_view:views.featured_articles.page_1",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": {
"display_id": "page_1",
Expand All @@ -536,7 +536,7 @@ exports[`getMenu() fetches menu items for a menu 1`] = `
"enabled": true,
"expanded": false,
"id": "views_view:views.recipes.page_1",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": {
"display_id": "page_1",
Expand Down Expand Up @@ -631,7 +631,7 @@ exports[`getMenu() fetches menu items for a menu with locale 1`] = `
"enabled": true,
"expanded": false,
"id": "standard.front_page",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": [],
"options": [],
Expand All @@ -651,7 +651,7 @@ exports[`getMenu() fetches menu items for a menu with locale 1`] = `
"enabled": true,
"expanded": false,
"id": "views_view:views.featured_articles.page_1",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": {
"display_id": "page_1",
Expand All @@ -674,7 +674,7 @@ exports[`getMenu() fetches menu items for a menu with locale 1`] = `
"enabled": true,
"expanded": false,
"id": "views_view:views.recipes.page_1",
"items": undefined,
"items": null,
"menu_name": "main",
"meta": {
"display_id": "page_1",
Expand Down
Loading