Fix PHP 8.4 incompatibility #869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module throws some warnings about "Implicitly marking a parameter as nullable is deprecated since PHP 8.4."
|
@arnested is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for this @arnested. Just adding a patch here with your changes so that I can apply it in my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module throws some warnings about "Implicitly marking a parameter as nullable is deprecated since PHP 8.4."
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterstarters/pages-starterGitHub Issue: #870
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Adjusts the method signatures regarding implicit nullable parameters to be compatible with PHP 8.4.