This repository was archived by the owner on Nov 30, 2025. It is now read-only.
feat: Preserve scalar styles and YAML tags when serializing YamlNode#777
Open
Tomas-Jakubec wants to merge 2 commits intocharleskorn:mainfrom
Open
feat: Preserve scalar styles and YAML tags when serializing YamlNode#777Tomas-Jakubec wants to merge 2 commits intocharleskorn:mainfrom
Tomas-Jakubec wants to merge 2 commits intocharleskorn:mainfrom
Conversation
Author
|
Corrected the style using spotlessKotlinApply. |
Author
Author
|
@charleskorn can you review the PR please? |
Author
|
@charleskorn please review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes loss of scalar style and YAML tag information during round-trip serialization of
YamlNodes. Resolves issue #749.Problem
Currently
YamlScalardoes not retain the original scalar style, making it impossible to distinguish between:Additionally, YAML tags present in the parsed input were not emitted during serialization.
Root cause
YamlNoderelied on generic Kotlinx Serialization paths that discarded style and tag metadata.Solution
YamlNodeScalarStyle) mapped to SnakeYAML engine styles.YamlNodesubclasses toYamlOutput, separating it from standard Kotlinx Serialization logic to avoid interference and to centralize style/tag handling.Key changes
YamlOutputto take responsibility forYamlNodeencoding.Backward compatibility
Performance
Risks / considerations
YamlScalarprogrammatically may now wish to specify a style explicitly. However, not specifying it results in original behavior.Testing
Closes: #749
Let me know if a changelog entry format needs adjustment.