Adds git info support for windows #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better organized Made the windows api more consistent with linux ignoring std err
Owner
|
Hi @Allotec, sorry for only now geting back to you. Unfortunately, I have no windows system to test this with. Actually, I also don't really have a compatible unix system to test this anymore 😅 Would you be interested in taking this project over? As it stands right now, it's barely maintained at all (by me) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #22 which adds git info support for windows. It is implemented just like the Linux version (ie using subprocess shells). Unfortunately on windows processes are much heavier so it is pretty slow. I think to get it as fast as the Linux version we would have to depend on something like luagit2.
I'm not sure if luagit2 ships with the actual C library or that needs to be installed separately. It's up to you whether or not this patch set is good enough or I should explore using the libgit2 bindings for windows.