fix: ship plugin.yaml in Helm 3 format for cross-version compatibility#237
Merged
nerdeveloper merged 2 commits intomainfrom Feb 9, 2026
Merged
fix: ship plugin.yaml in Helm 3 format for cross-version compatibility#237nerdeveloper merged 2 commits intomainfrom
nerdeveloper merged 2 commits intomainfrom
Conversation
Validates that: - plugin.yaml and testdata/plugin-helm3.yaml parse with Helm 3's strict unmarshaller - testdata/plugin-helm4.yaml parses with Helm 4's strict V1 unmarshaller - plugin.yaml uses legacy format (no apiVersion) for Helm 4 compatibility These tests would have caught the v0.11.0 regression where mixed Helm 3/4 fields broke both versions.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin.yamlin Helm 3 (legacy) format so both Helm 3 and Helm 4 can parse ittestdata/plugin-helm4.yamlto be a pure Helm 4 V1 manifest (remove Helm 3 fields)testdata/plugin-helm3.yaml(remove deprecateduseTunnel)Problem
The v0.11.0
plugin.yamlmixed Helm 3 and Helm 4 fields, breaking both versions:apiVersion,type,runtime, etc.) →json: unknown field "apiVersion"([Bug Report][v0.11.0] error unmarshaling JSON: while decoding JSON: json: unknown field "apiVersion" #234)downloaders,useTunnel,hooks) →field downloaders not found in type plugin.MetadataV1([Bug Report][v0.11.0] Not working in helm version 4.1.0 on Ubuntu 22.04.5 LTS #235)How this works
plugin.yamluses Helm 3 (legacy) format — parseable by both Helm 3 and Helm 4apiVersion) and uses non-strict parsingscripts/install_plugin.sh) detects the Helm version and swaps to the appropriate manifest fromtestdata/Fixes #234, fixes #235
Test plan
helm plugin install .succeeds on Helm 4.1.0go test ./...— 16/16)