Skip to content

Conversation

@chase-turner
Copy link
Owner

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

// Write code here
function rockPaperScissors(hand1, hand2){
if (hand1 === 'rock' && hand2 === 'rock') {
return "It's a tie!";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems sound but you are repeating yourself a lot, think of a way reduce this

@reneemeyer
Copy link

Chase, nice job! You could make your JS a little less cluttered to make this even better. In class I went over a couple of ways to do this, let me know if you need a refresher. Go ahead, make changes, push to this branch to update the PR. Come back to the PR on github, once the comments are addressed, click merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants