Ensure connected SSHD session inherits PATH from parent process.

[rgrunber]

What issues does this PR fix?

1. Create a DevWorkspace using the "Visual Studio Code (Desktop) (SSH) editor, and an empty workspace.
2. From the web terminal for the UDI image : echo $PATH | tr ':' '\n' and you'll see /home/tooling/go/bin present.
3. Now connect to that same workspace over SSH and perform the same command from (2). You won't find /home/tooling/go/bin on the path.

The problem is the first line at

che-code/build/scripts/sshd.start

Line 68 in cf1d448

echo 'export PATH=$PATH:$HOME/bin' >> $HOME/.profile

The single quotes mean the PATH references on the right-hand-side is never expanded and at runtime it's too late. We even avoid injecting it at

che-code/build/scripts/sshd.start

Lines 69 to 71 in cf1d448

	# Set up environment variables injected into PID 1 (.profile & .bashrc)
	env | grep -v 'PATH=' | sed 's|^|export |' >> $HOME/.profile

because we just modified it above.

This PR should fix this so that it inherits the PATH from the parent, but also includes the $HOME/bin location where the additional scripts needed for the SSHD setup are present.

• I have not tested this thoroughly at all but seems to fix the issue.

Summary by CodeRabbit

• Chores
  • Refined environment variable initialization logic to ensure consistent PATH configuration during application startup.

[github-actions]

Click here to review and test in web IDE:

[coderabbitai]

📝 Walkthrough

Walkthrough

The sshd startup script's environment variable injection logic was modified to export all environment variables from PID 1 and then explicitly append a PATH augmentation line, rather than filtering out PATH variables during the initial export phase.

Changes

Cohort / File(s)	Summary
Environment Variable Injection build/scripts/sshd.start	Changed from excluding PATH variables via grep filter during env export to exporting all variables followed by explicit export PATH=$PATH:$HOME/bin appended to .profile.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• azatsarynnyy
• vitaliy-guliy
• RomanNikitenko

Poem

🐰 The PATH now flows so clear and bright,
All variables exported, set just right,
Then home and bin join in the dance,
With every shell, a second chance! 🌿

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: ensuring SSH sessions inherit the parent process PATH, which is the primary objective and central change of this PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

build/scripts/sshd.start (1)

70-72: Make shell init file generation idempotent.

Using >> on Line 70 and Line 72 appends duplicate exports on each restart when $HOME is persistent. Prefer rewriting the generated block each run (or guarding with markers) to avoid unbounded growth and repeated PATH entries.

♻️ Example refactor

-env | sed 's|^|export |' >> $HOME/.profile
-echo 'export PATH=$PATH:$HOME/bin' >> $HOME/.profile
-cat $HOME/.profile >> $HOME/.bashrc
+{
+  env | sed 's|^|export |'
+  echo 'export PATH=$PATH:$HOME/bin'
+} > "$HOME/.profile"
+cat "$HOME/.profile" > "$HOME/.bashrc"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@build/scripts/sshd.start` around lines 70 - 72, The script currently appends
environment exports and PATH lines unconditionally using the lines containing
"env | sed 's|^|export |' >> $HOME/.profile" and "echo 'export
PATH=$PATH:$HOME/bin' >> $HOME/.profile" which causes duplicate entries on each
restart; change this to an idempotent update by writing a marked block to
$HOME/.profile (or removing any existing marker-delimited block first) and then
appending the single block (including the exported env lines and PATH update)
once, and ensure you update .bashrc only once by replacing the "cat
$HOME/.profile >> $HOME/.bashrc" behavior with either sourcing the marker block
into .bashrc or adding a guard (grep for the marker or PATH entry) before
modifying .bashrc.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@build/scripts/sshd.start`:
- Around line 70-72: The script currently appends environment exports and PATH
lines unconditionally using the lines containing "env | sed 's|^|export |' >>
$HOME/.profile" and "echo 'export PATH=$PATH:$HOME/bin' >> $HOME/.profile" which
causes duplicate entries on each restart; change this to an idempotent update by
writing a marked block to $HOME/.profile (or removing any existing
marker-delimited block first) and then appending the single block (including the
exported env lines and PATH update) once, and ensure you update .bashrc only
once by replacing the "cat $HOME/.profile >> $HOME/.bashrc" behavior with either
sourcing the marker block into .bashrc or adding a guard (grep for the marker or
PATH entry) before modifying .bashrc.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 47d4ef32-e717-4100-8fd5-2d9b1f853b43

📥 Commits

Reviewing files that changed from the base of the PR and between cf1d448 and c040b26.

📒 Files selected for processing (1)

• build/scripts/sshd.start

[github-actions]

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-673-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-673-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-673-dev-amd64