[DO NOT MERGE] Add checkout step for che e2e tests#675
[DO NOT MERGE] Add checkout step for che e2e tests#675dmytro-ndp wants to merge 3 commits intoche-incubator:mainfrom
Conversation
Added a step to checkout che e2e tests before running smoke tests.
dmytro-ndp
requested review from
RomanNikitenko,
azatsarynnyy,
rgrunber and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
dmytro-ndp
changed the title
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflow removed local Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/smoke-test-pr-check.yaml:
- Line 155: The trailing space after the line-continuation backslash in the
docker run volume line "-v ${LOCAL_TEST_DIR}/tests/e2e:/tmp/e2e:Z \ " breaks the
shell continuation; edit that line so the backslash is the final character with
no following space (i.e., change "-v ${LOCAL_TEST_DIR}/tests/e2e:/tmp/e2e:Z \ "
to have the backslash immediately at end of line) to restore proper line
continuation in the workflow.
- Around line 132-134: The checkout step "Checkout che e2e tests" currently
clones into ${LOCAL_TEST_DIR} without pinning a ref and your proposed change
created a path mismatch; fix by pinning the repo using git clone --depth 1
--branch <REF> and clone into ${LOCAL_TEST_DIR}/che (so the cloned code path
matches existing docker volume mounts that expect ${LOCAL_TEST_DIR}/tests/e2e),
OR if you prefer the new layout, update that git clone destination to
${LOCAL_TEST_DIR}/che-e2e-src and also update all docker run volume mounts that
reference ${LOCAL_TEST_DIR}/tests/e2e to point to ${LOCAL_TEST_DIR}/che-e2e-src
(ensure consistency for the ${LOCAL_TEST_DIR} variable and the "Checkout che e2e
tests" step).
- Around line 132-134: The docker run command in the workflow currently uses a
backslash followed by a space to continue the line, which breaks shell
continuation; locate the multi-line "docker run" command in the workflow and
make the backslash the very last character on the continued lines (remove the
trailing space after the backslash) or alternatively join the arguments on one
line or wrap them in quotes so the YAML block preserves intended spacing; ensure
each continuation uses "\" immediately before the newline so the shell sees a
proper line continuation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 32077e67-edd3-4d07-a92a-419b929ff4e7
📒 Files selected for processing (1)
.github/workflows/smoke-test-pr-check.yaml
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-675-amd64 |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/smoke-test-pr-check.yaml (1)
29-31:⚠️ Potential issue | 🟠 MajorPin the e2e checkout ref for reproducible smoke tests.
The
git clonestill uses the repository's default branch head without pinning a specific ref. This causes smoke test outcomes to drift over time independent of this PR, making failures non-reproducible.Consider adding a
--branchflag or using a specific commit SHA:Proposed fix
- name: Checkout che e2e tests run: | - git clone --depth 1 https://github.com/eclipse-che/che ${LOCAL_TEST_DIR}/che + git clone --depth 1 --branch main https://github.com/eclipse-che/che ${LOCAL_TEST_DIR}/cheFor even better reproducibility, consider using a specific tag or commit SHA, or parameterizing the ref via an environment variable.
,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/smoke-test-pr-check.yaml around lines 29 - 31, Update the "Checkout che e2e tests" step that runs the git clone so the clone is pinned to a specific ref: change the git clone invocation used in that step to include a --branch (or --single-branch) argument pointing to a tag/commit or to an environment variable (e.g. CHE_REF) so CI uses a stable, reproducible ref instead of the repo default branch; ensure the step's git clone line references that env var or explicit SHA/tag and document/validate the variable in the workflow inputs or env section.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/smoke-test-pr-check.yaml:
- Around line 29-31: Update the "Checkout che e2e tests" step that runs the git
clone so the clone is pinned to a specific ref: change the git clone invocation
used in that step to include a --branch (or --single-branch) argument pointing
to a tag/commit or to an environment variable (e.g. CHE_REF) so CI uses a
stable, reproducible ref instead of the repo default branch; ensure the step's
git clone line references that env var or explicit SHA/tag and document/validate
the variable in the workflow inputs or env section.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b1924351-1608-4203-8e32-6fe492c5b35e
📒 Files selected for processing (1)
.github/workflows/smoke-test-pr-check.yaml
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-675-amd64 |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-675-amd64 |
1 participant
Add a step to checkout che e2e tests before running smoke tests.
What does this PR do?
Verify if Smoke Test failure for the che-code is a test container image problem, or test code problem.
What issues does this PR fix?
eclipse-che/che#23779
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderSummary by CodeRabbit