feat: add save file task example code#63
Open
dbwodlf3 wants to merge 7 commits intocheahjs:mainfrom
Open
Conversation
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
| from lib.utils.level_util import loadSavJson, dumpSavJson | ||
| from lib.utils.charactersave_util import getRawPlayers | ||
|
|
||
| file_path = os.path.join(os.path.dirname(__file__), "Level.sav.json") |
Author
There was a problem hiding this comment.
Actually, I hope that someone will change this part to a normalized form, similar to a save tool task template.
(I will do it, not now, but in a week)
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
| @@ -0,0 +1,9 @@ | |||
| from dataclasses import dataclass, fields | |||
|
|
|||
| class Null: | |||
Author
There was a problem hiding this comment.
in json file have null and "NoneType". but python doesn't know what is null or None.
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
dbwodlf3
commented
Jan 27, 2024
| from lib.utils.mapobjectsave_util import getRawMapObjectData, removeRawMapObjectById | ||
| from lib.utils.basecampsave_util import getRawBaseCampSaveData | ||
|
|
||
| file_path = os.path.join(os.path.dirname(__file__), "initedPlayersPoint.json") |
Author
|
And, add Test code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added some type parsing as Python types and written some tasks.
I will add test code and refactor the codebase.
If you have any suggestions to improve this project, please advise me. Your input would be greatly appreciated.