feat: add payment setups support #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armando-rodriguez-cko
force-pushed
the
feature/new-endpoint-payment-setups
branch
from
4a75b91 to
d880d87
Compare
- Add .ruby-version (3.1.0) for rbenv/rvm - Add .overcommit.yml for pre-commit hooks (validates lib/ only) - Update .gitignore to exclude compiled gem artifacts (*.gem)
- Update required Ruby version: >= 2.6.0 -> >= 2.7.0 (breaking change) - Update RuboCop: ~> 1.36 -> ~> 1.82 - Update Faraday: ~> 1.10 -> >= 2.0, < 3.0 - Update faraday-follow_redirects: ~> 0.3.0 -> ~> 0.5.0 - Update faraday-multipart: ~> 1.0 -> ~> 1.2 - Update overcommit: ~> 0.60 -> ~> 0.60 - Document Ruby 2.7+ requirement in README
- Update build-master.yml: Ruby [2.6, 3.1] -> [2.7, 3.1, 3.3] - Update build-pull-request.yml: Ruby [2.6, 3.1] -> [2.7, 3.1, 3.3] - Update build-release.yml: Ruby 2.6 -> 3.1
- Gemfile: add trailing newline - Rakefile: use single quotes for strings
Auto-correct 132 instances of super without parentheses when passing arguments. Changed from 'super SomeClass::CONSTANT' to 'super(SomeClass::CONSTANT)' for better code clarity.
armando-rodriguez-cko
force-pushed
the
feature/new-endpoint-payment-setups
branch
from
d880d87 to
4d447c1
Compare
- Use explicit keyword argument splat (**opts) to avoid Ruby 2.7 hash-to-kwargs ambiguity - Add overcommit to Gemfile for consistent development environment - Change ENV[] to ENV.fetch() for better error handling
Explicitly pass params: nil to invoke() in invoke_post, invoke_put, and invoke_patch to prevent Ruby 2.7 from interpreting hash arguments as keyword arguments. This resolves ArgumentError: unknown keywords when passing hashes to update_payment_setup and other methods that use invoke_put. - Add params: nil to all HTTP method wrappers (post, put, patch) - Simplify payment setups tests to match PHP SDK pattern - Use ENV.fetch() for better error handling - Update helper to use explicit keyword argument splat
|
armando-rodriguez-cko
changed the title
robert-goheen-cko
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the SDK, focusing on raising the minimum supported Ruby version, updating dependencies, improving development tooling, and making minor code cleanups. The changes ensure better compatibility with modern Ruby versions, add automated code quality checks, and clarify project requirements and setup.
Ruby version and dependency updates:
checkout_sdk.gemspecand updated the.ruby-versionfile to 3.1.0. Ruby 2.6 is no longer supported. [1] [2]checkout_sdk.gemspecto use newer versions ofrubocop,overcommit, and thefaradaysuite.Development tooling and documentation:
overcommitas a development dependency and included a new.overcommit.ymlconfiguration file to enable RuboCop checks as pre-commit hooks. [1] [2]README.mdwith new requirements, tested Ruby versions, and detailed instructions for setting up and using Overcommit for Git hooks. [1] [2]Codebase improvements and minor cleanups:
Rakefileto use single quotes forrequirestatements for style consistency.params: nilfor consistency.payments_setupsattribute and initialization inCheckoutApi. [1] [2] [3]