rpc/log: return first error always #2661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
reviewed
May 7, 2025
criu/log.c
Outdated
| @@ -123,6 +127,23 @@ int log_keep_err(void) | |||
| return 0; | |||
| } | |||
|
|
|||
| int log_keep_shr_err(void) | |||
There was a problem hiding this comment.
log_keep_err does the same thing, doesn't it?
There was a problem hiding this comment.
The new function creates new memory mapping with MAP_SHARED, this memory region is shared between a parent and its children. It's useful when a rpc server spawns a child but does not have access to the child's error buffer when something goes wrong
There was a problem hiding this comment.
log_keep_err uses shmalloc, it creates shared regions too.
There was a problem hiding this comment.
Uh, I was looking at the wrong shmalloc definition. I've updated it to just use log_keep_err.
Use shared first error buffer to return correct first error in rpc. Fixes: checkpoint-restore#338 Signed-off-by: Ivan Pravdin <ipravdin.official@gmail.com>
ivpravdin
force-pushed
the
return-first-err-rpc
branch
from
588c3b6 to
d105f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce interface to criu-log component to allocate
first error buffer shared between a parent and its children.
Use shared first error buffer to return correct
first error in rpc.
Fixes: #338