Skip to content

Handling item = null #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
premii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handling item = null #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions lib/hnapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,37 +48,39 @@ var api = {
// Throw them all into an array
Promise.all(itemFetches).then(function(res){
var apiRes = res.map(function(item){
var commentsCount = item.descendants || 0;

var output = {
id: item.id,
title: item.title,
points: item.score,
user: item.by,
time: item.time, // Unix timestamp
time_ago: moment(item.time*1000).fromNow(),
comments_count: commentsCount,
type: typeMapping[item.type] || item.type
};

if (item.url){
output.url = item.url;
output.domain = url.parse(item.url).hostname.replace(/^www\./i, '');
} else {
output.url = 'item?id=' + item.id; // Simulate "local" links
}

// If it's a job, username and points are useless
if (item.type == 'job'){
output.user = output.points = null;
}

// Identify type=ask
if (item.type == 'story' && output.url.match(/^item/i) && item.title.match(/^ask/i)){
output.type = 'ask';
if (item) {
var commentsCount = item.descendants || 0;

var output = {
id: item.id,
title: item.title,
points: item.score,
user: item.by,
time: item.time, // Unix timestamp
time_ago: moment(item.time*1000).fromNow(),
comments_count: commentsCount,
type: typeMapping[item.type] || item.type
};

if (item.url){
output.url = item.url;
output.domain = url.parse(item.url).hostname.replace(/^www\./i, '');
} else {
output.url = 'item?id=' + item.id; // Simulate "local" links
}

// If it's a job, username and points are useless
if (item.type == 'job'){
output.user = output.points = null;
}

// Identify type=ask
if (item.type == 'story' && output.url.match(/^item/i) && item.title.match(/^ask/i)){
output.type = 'ask';
}

return output;
}

return output;
});

fn(null, apiRes);
Expand Down