Limit ffi to 1.17.0 for 18-stable

[tpowell-progress]

Description

Chef 18 in habitat plan is unable to load ffi-libarchive with ffi version 1.17.1. Putting an upper bound on ffi at 1.17.0 prevents this breakage, but it has to be added to ohai as well due to post-bundle-install.rb manually installed gems bundled in ohai. FFI issue #1139 has been opened upstream.

Broken build example

Symptoms:

ffi-libarchive could not be loaded, libarchive is probably not installed on system, archive_file will not be available

# NameError:
#   uninitialized constant Archive::EXTRACT_OWNER
#
#               owner: Archive::EXTRACT_OWNER,
#                             ^^^^^^^^^^^^^^^
#   ./lib/chef/resource/archive_file.rb:146:in 'extract_option_map'

 

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarqube-for-infrastructure-prod]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tpowell-progress]

@tpowell-progress File bug upstream to ffi for the ffi_c issue