[18-stable:backport] filesystem plugin transition #1902
Merged
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2015, I wrote a new filesystem plugin (#559), because the original one used non-unique keys and so the data was not only incomplete but inconsistent. Since it was backwards incompatible, we called it `filesystem2`, and agreed to a migration path. That original PR only implemented it for linux, however, and it shortly followed with #564 for Darwin/OSX. The plan was, at that time to keep both for one major version (give people the chance to migrate to fs2), then for one major version make both names (`filesystem` and `filesystem2`) so that people could move back to the name `filesystem`, and then we'd finally drop the `filesystem2` name. Unfortunately, other platforms never got FS2 support, so this got hairy. In 2018 I wrote #181 which unified the various platforms' plugins so it was easier to implement fs2 on more platforms. Shortly there after I wrote #1266 that implemented fs2 for the rest of the unixes. And finally, I wrote #1267 implemented Windows to filesystem2. This was all still before Chef 17. For Chef 17 I wrote #1662 which finally made windows have the new data in the original name, the second-to-last-step. The plan being that in 18 we'd finally remove the `filesystem2` name... but we forgot to do that. This, is the final bit - remove all references to filesystem2. Closes #1872 Signed-off-by: Phil Dibowitz <phil@ipom.com>
rishichawda
changed the title
rishichawda
changed the title
|
|
johnmccrae
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport of #1873
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.