Strip hostnamectl icons #1909
Open
Strip hostnamectl icons #1909
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RHEL 10 (and other modern systemd-based distributions), the hostnamectl command has been updated to include visual icons using UTF-8 characters for the Chassis field. This change is part of the upstream systemd project's effort to make the CLI output more visually informative for users. Instead of just seeing the word "laptop" or "server," you now see a corresponding symbol. This leads to following: ``` warning: JSON.generate: UTF-8 string passed as BINARY, this will raise an encoding error in json 3.0 ``` Signed-off-by: Joseph J Nuspl Jr <nuspl@nvwls.com>
|
jaymzh
requested changes
Dec 27, 2025
| key, val = line.split(": ", 2) | ||
|
|
||
| # strip visual icons produced by newer versions of systemd | ||
| val.gsub!(/ [^[:ascii]]*$/, "") |
Collaborator
There was a problem hiding this comment.
I like where you're going with this but non-ascii isn't quite what you want, which is why you're having to add anchors. This will grab all unicode+modifiers and squeeze the spaces:
irb(main):025> re = /\p{So}\p{Mn}*/u
=> /\p{So}\p{Mn}*/
irb(main):031> vals = ["Chassis: desktop 🖥️", "Chassis: 🖥️ desktop", "🖥️ Chassis: desktop"]
irb(main):033> vals.map { |val| val.gsub(re, "").squeeze(" ").strip }
=> ["Chassis: desktop", "Chassis: desktop", "Chassis: desktop"]
This handles all sort of cases they can throw at us without any unnecessary removals.
Suggested change
| val.gsub!(/ [^[:ascii]]*$/, "") | |
| val.gsub!(/\p{So}\p{Mn}*/u, "").squeeze(" ").strip |
Ideally we would also add a unittest for this with those test cases....there's already a ton of hostname tests in spec/unit/plugins/hostname_spec.rb you can use as a template.
johnmccrae
added
the
Status: Waiting on Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In RHEL 10 (and other modern systemd-based distributions), the hostnamectl command has been updated to include visual icons using UTF-8 characters for the Chassis field.
This change is part of the upstream systemd project's effort to make the CLI output more visually informative for users. Instead of just seeing the word "laptop" or "server," you now see a corresponding symbol.
This leads to following:
Related Issue
#1908
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.