Implement deep cloning for opacities map in RadiationBandOptionsImpl

[Copilot]

The clone() method in RadiationBandOptionsImpl performs shallow copy of the opacities map, causing the cloned object to share OpacityOptionsImpl instances with the original. Modifications to opacity options in either object affect both.

Changes

• Deep clone opacities map: Clear the shallow-copied map and clone each OpacityOptions entry individually using its clone() method
• Ensures true independence between cloned and original RadiationBandOptionsImpl instances

std::shared_ptr<RadiationBandOptionsImpl> clone() const {
  auto op = std::make_shared<RadiationBandOptionsImpl>(*this);
  if (op->disort() != nullptr) {
    op->disort() = op->disort()->clone();
  }
  if (op->toon() != nullptr) {
    op->toon() = op->toon()->clone();
  }
  if (op->opacities().size() > 0) {
    auto& opacities_ref = op->opacities();
    opacities_ref.clear();
    for (auto const& [k, v] : opacities()) {
      opacities_ref[k] = v->clone();
    }
  }
  return op;
}

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This pull request fixes a shallow copy issue in the RadiationBandOptionsImpl::clone() method by implementing deep cloning for the opacities map. Previously, cloned objects shared OpacityOptionsImpl instances with the original, causing unintended modifications to affect both objects.

Changes:

• Added deep cloning logic for the opacities map that iterates through each entry and clones it using the OpacityOptions::clone() method
• Maintains consistency with existing clone patterns for disort() and toon() members

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.