-
Notifications
You must be signed in to change notification settings - Fork 51
fix: Refine Docker Image tagging approach [DEV-5517] #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* docs: Add v4-minor upgrade binaries file * Switch to v4.1.6 instead of beta release
* docs: Add v4-minor upgrade binaries file * Switch to v4.1.6 instead of beta release * Add mainnet v4-minor binaries
…Optimise sleep funtions in fee abs tests [DEV-5515] (#942) * optimized sleep and wait functions in tests * revert wait time
|
Task linked: DEV-5517 Refine Docker Image tagging approach |
|
Is this PR AI-generated/assisted? What is the purpose of it? It seems to be replicating out of the box functionality that Docker build function offers, but with use of bash scripts which is not great for idempotency. |
Good catch 👍. We will be looking at alternatives, solely using Docker image metadata. And for context, we wanted to distinguish beta releases from production ones, essentially removing |
Eengineer1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Approved 👍.
Merging this into develop is expected to create a new staging-latest Docker image and later when successively merged down into main to also create a new production-latest Docker image.
No description provided.