Skip to content

Conversation

@kaustubhkapatral
Copy link
Collaborator

No description provided.

filipdjokic and others added 5 commits November 10, 2025 13:30
* docs: Add v4-minor upgrade binaries file

* Switch to v4.1.6 instead of beta release
* docs: Add v4-minor upgrade binaries file

* Switch to v4.1.6 instead of beta release

* Add mainnet v4-minor binaries
…Optimise sleep funtions in fee abs tests [DEV-5515] (#942)

* optimized sleep and wait functions in tests

* revert wait time
@ankurdotb
Copy link
Contributor

@ankurdotb
Copy link
Contributor

Is this PR AI-generated/assisted? What is the purpose of it?

It seems to be replicating out of the box functionality that Docker build function offers, but with use of bash scripts which is not great for idempotency.

@Eengineer1
Copy link
Member

Is this PR AI-generated/assisted? What is the purpose of it?

It seems to be replicating out of the box functionality that Docker build function offers, but with use of bash scripts which is not great for idempotency.

Good catch 👍. We will be looking at alternatives, solely using Docker image metadata. And for context, we wanted to distinguish beta releases from production ones, essentially removing production-latest tag from develop branches and using staging-latest instead and thus tagging with production-latest stable releases only generated on main.

Eengineer1
Eengineer1 previously approved these changes Dec 2, 2025
Copy link
Member

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Approved 👍.

Merging this into develop is expected to create a new staging-latest Docker image and later when successively merged down into main to also create a new production-latest Docker image.

@Eengineer1 Eengineer1 changed the base branch from main to develop December 2, 2025 15:10
@Eengineer1 Eengineer1 dismissed their stale review December 2, 2025 15:10

The base branch was changed.

@Eengineer1 Eengineer1 merged commit 9d76878 into develop Dec 4, 2025
18 checks passed
@Eengineer1 Eengineer1 deleted the kappa/refine-docker-tag branch December 4, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants