Skip to content

Uncaught socket exception during timeout handling #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Uncaught socket exception during timeout handling #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cheroot/ssl/pyopenssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,14 @@ def _safe_call(self, is_reader, call, *args, **kwargs): # noqa: C901
except SSL.WantWriteError:
time.sleep(self.ssl_retry)
except SSL.SysCallError as e:
if is_reader and e.args == (-1, 'Unexpected EOF'):
return b''
if e.args == (-1, 'Unexpected EOF'):
if is_reader:
return b''
else:
# See #210. Prevents DOS attack caused by
# silent connections lasting beyond connection
# timeout length.
raise errors.FatalSSLAlert(*e.args)

errnum = e.args[0]
if is_reader and errnum in errors.socket_errors_to_ignore:
Expand Down
Loading