Open
Conversation
davy-tw
force-pushed
the
fix/reduce_spaces_in_bopomofo
branch
from
7e9950b to
06f65f7
Compare
Member
|
Improve the subject of Git commit message. At least, summarize the work first. |
Billy4195
reviewed
Apr 12, 2017
| TEST_F(TestBopomofoUtil, ReduceDuplicatedSpacesInsideBopomofo) | ||
| { | ||
| ASSERT_EQ(0, QString::compare("ㄘㄜˋ ㄕˋ", BopomofoUtil::normalize("ㄘㄜˋ ㄕˋ"))); | ||
| ASSERT_EQ(0, QString::compare("ㄘㄜˋ ㄕˋ", BopomofoUtil::normalize("ㄘㄜˋ ㄕˋ"))); |
There was a problem hiding this comment.
Should this test also including the test of replacing "一" to "ㄧ" and "丫" to "ㄚ"?
This commit cover this feature, too.
Member
Author
There was a problem hiding this comment.
Nop, this PR is just moving the original part of replacing ambugity words into a sperated file and adding the reducing duplicated spaces function.
But, yes, we still need tests for replacing ambugity words, that's why I move it. After this PR, I'll submit another PR for the tests.
Fixed chewing#204. Move `testBopomofo` method from UserphraseModel into BopomofoUtil for testing.
davy-tw
force-pushed
the
fix/reduce_spaces_in_bopomofo
branch
from
06f65f7 to
22a954f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #204, replacing all duplicated spaces (included single tab and tabs) into single space.
I move
testBopomofomethod fromUserphraseModelinto a new utilBopomofoUtil, IMO, this function is not that related to the model.And we can create tests for this more easily (without including the main program).
cc @jserv @czchen