Fixes to work with PHPUnit 3.6 and PHP 5.3#23
Open
shupp wants to merge 1 commit intochibimagic:masterfrom
Open
Fixes to work with PHPUnit 3.6 and PHP 5.3#23shupp wants to merge 1 commit intochibimagic:masterfrom
shupp wants to merge 1 commit intochibimagic:masterfrom
Conversation
* Throw/Expect new WebDriver_Exception instead of Exception * Add default $six_hex value of null to eliminate warnings (which become exceptions in PHPUnit's error handling) * Use preg_split() instead of the deprecated split() to eliminate deperecation warnings * Expect PHPUnit_Framework_ExpectationFailedException when appropriate
|
Thank you, this is just what I needed. With PHPUnit 3.6.10 and PHP 5.5.3 (on Xubuntu 13.10) this patch mostly worked, with one exception changed: diff --git a/WebDriverColorTest.php b/WebDriverColorTest.php
index 0c93a31..ba26bc2 100644
--- a/WebDriverColorTest.php
+++ b/WebDriverColorTest.php
@@ -39,7 +39,7 @@ class WebDriverColorTest extends PHPUnit_Framework_TestCase {
/**
* @dataProvider invalid_colors
- * @expectedException Exception
+ * @expectedException PHPUnit_Framework_Error_Notice
*/
public function test_invalid_colors($input) {
WebDriver::CanonicalizeCSSColor($input);I noticed also that the maintainer already updated split() -> preg_split(), but did not merge the rest of this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(which become exceptions in PHPUnit's error handling)
deperecation warnings