fix invalid escape sequences and references to $this->send_modifier#9
Open
kdebisschop wants to merge 5 commits intochibimagic:masterfrom
kdebisschop:master
Open
fix invalid escape sequences and references to $this->send_modifier#9kdebisschop wants to merge 5 commits intochibimagic:masterfrom kdebisschop:master
kdebisschop wants to merge 5 commits intochibimagic:masterfrom
kdebisschop:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made two changes to your source. The first may mot affect running code at this point, but Zend Studio pints out that \u is an invalid escape sequence in double quotes (I presume because there is abiguity around whether \u is the escape or whether you mean to indicate a unicode character). Same for \n in regexes that are double quoted. The first patch just fixes those so Zend no longer warns about that code.
The second patch is for send_modifier() which Zend reports as undefined. From he context, I take it that you meant $this->send_modifier()
I hope you find these useful. I know I've enjoyed your library, so thanks for the good work.
Karl