Open
Conversation
DebateXML is an interchange and archival format for debate tournaments of multiple styles, including BP. This commit adds a quick DebateXML exporter function to tournament tab- masters, which is also available after the tournament closes. The link is available under the Tournament drop-down with the Tabbie1/DebReg integrations. A helper function was also added to the tournament model to fetch all questions at once, rather than just a type thereof. Further, novice status was not implemented in the exporter as it does not seem to be complete. Schema: TabbycatDebate/DebateXML#4
tienne-B
commented
Jun 24, 2019
| $institutions = []; | ||
| foreach ($adjudicator->getSocieties() as $inst) | ||
| { | ||
| array_push($institutions, self::SOCIETY_PREFIX . $inst->id); |
Contributor
Author
There was a problem hiding this comment.
Are adjudicators associated with only one society in a tournament? I took it as no, but if I'm wrong, is it appropriate to release all current affiliations? Same for speakers above.
tienne-B
commented
Jun 24, 2019
| /** | ||
| * @return \yii\db\ActiveQuery | ||
| */ | ||
| public function getAllQuestions() |
Contributor
Author
There was a problem hiding this comment.
Is there a standard style for code in this project? For example, this file uses spaces while TournamentController.php uses tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebateXML is an interchange and archival format for debate tournaments of multiple styles, including BP.
This commit adds a quick DebateXML exporter function to tournament tab-masters, which is also available after the tournament closes. The link is available under the Tournament drop-down with the Tabbie1/DebReg integrations.
A helper function was also added to the tournament model to fetch all questions at once, rather than just a type thereof. Further, novice status was not implemented in the exporter as it does not seem to be complete.
I have not measured the performance of the exporter as I do not have a dataset to work with. It would be good if one were available for development/tests.
Schema: TabbycatDebate/DebateXML#4 (and more information about the project available in the repo)