Support comments for video and chat conversations#416
Closed
chiimagnus wants to merge 17 commits intomainfrom
Closed
Support comments for video and chat conversations#416chiimagnus wants to merge 17 commits intomainfrom
chiimagnus wants to merge 17 commits intomainfrom
Conversation
- Renamed functions and variables for consistency, changing `listArticleCommentsByCanonicalUrl` to `listCommentsByCanonicalUrl`, `addArticleComment` to `addComment`, and `deleteArticleCommentById` to `deleteCommentById`. - Updated all relevant tests and mocks to reflect the new naming conventions. - Introduced new unit tests for comments storage in IndexedDB, ensuring functionality for adding, listing, and deleting comments. - Enhanced existing tests to accommodate the refactored functions and ensure proper behavior in various scenarios. - Migrated legacy article comments to the new comments store in schema migration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a comments sidebar for video and chat conversations, refactor existing article comments to a unified comments system, and ensure compatibility with legacy data. Enhance synchronization with Notion and Obsidian for comments across different content types.