Update devcontainer.json with additional features #22
Conversation
Added extensions for Python, Docker, Node.js, and GitHub CLI to enhance the development container.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the dev container configuration by adding essential development tools and features needed for the Flask/Astro project stack.
- Adds VSCode extensions for Python, Docker, and Remote Containers
- Configures features for Node.js (v20), Python (v3.11), and GitHub CLI
- Adds development settings including port forwarding and workspace configuration
| }, | ||
| // Add Python for Python development | ||
| "ghcr.io/devcontainers/features/python:1": { | ||
| "version": "3.11" |
There was a problem hiding this comment.
The Python version is inconsistent with the CI/CD workflows. The GitHub Actions workflows use Python 3.13 (see .github/workflows/copilot-setup-steps.yml and .github/workflows/run-tests.yml), but this devcontainer specifies Python 3.11. This version mismatch could lead to compatibility issues between local development and CI/CD environments. Update to "3.13" to match the workflow configurations.
| "version": "3.11" | |
| "version": "3.13" |
| // Optionally set container settings for improved dev experience | ||
| "settings": { | ||
| "terminal.integrated.defaultProfile.linux": "bash", | ||
| "python.pythonPath": "/usr/local/bin/python3" |
There was a problem hiding this comment.
The python.pythonPath setting is deprecated in recent versions of the Python extension for VS Code. Use python.defaultInterpreterPath instead.
| "python.pythonPath": "/usr/local/bin/python3" | |
| "python.defaultInterpreterPath": "/usr/local/bin/python3" |
| }, | ||
| // Add Node.js for JavaScript/TypeScript development | ||
| "ghcr.io/devcontainers/features/node:1": { | ||
| "version": "20" |
There was a problem hiding this comment.
The Node.js version is inconsistent with the CI/CD workflows. The GitHub Actions workflows use Node.js version 22 (see .github/workflows/copilot-setup-steps.yml and .github/workflows/run-tests.yml), but this devcontainer specifies version 20. This version mismatch could lead to compatibility issues. Update to "22" to match the workflow configurations.
| "version": "20" | |
| "version": "22" |
| "workspaceMount": "source=${localWorkspaceFolder},target=/workspace,type=bind,consistency=cached", | ||
| "workspaceFolder": "/workspace" |
There was a problem hiding this comment.
The workspaceMount and workspaceFolder settings override the default mount behavior, which may cause issues with the universal devcontainer image being used. The mcr.microsoft.com/devcontainers/universal:latest image already has a predefined workspace location at /workspaces/<repository-name>. Unless there's a specific reason to override this, these settings should be removed to avoid potential path conflicts.
| "workspaceMount": "source=${localWorkspaceFolder},target=/workspace,type=bind,consistency=cached", | |
| "workspaceFolder": "/workspace" |
Added extensions for Python, Docker, Node.js, and GitHub CLI to enhance the development container.