Specify code review comments language as Spanish #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added requirement for code review comments to be in Spanish.
| - Check for security best practices, especially in workflows and dependencies. | ||
| - Add comments to code and workflows where necessary for clarity. | ||
| - Provide constructive feedback to improve code quality and maintainability. | ||
| - Code review comments should be in spanish |
There was a problem hiding this comment.
Corrected capitalization of 'spanish' to 'Spanish'.
Suggested change
| - Code review comments should be in spanish | |
| - Code review comments should be in Spanish |
| - Check for security best practices, especially in workflows and dependencies. | ||
| - Add comments to code and workflows where necessary for clarity. | ||
| - Provide constructive feedback to improve code quality and maintainability. | ||
| - Code review comments should be in spanish |
There was a problem hiding this comment.
[nitpick] This guideline may create inconsistency with the rest of the documentation and code review practices, which are currently in English. Consider whether this requirement aligns with the project's accessibility goals and contributor base, or if it should apply only to specific contexts.
Suggested change
| - Code review comments should be in spanish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added requirement for code review comments to be in Spanish.