Skip to content

improvements for voip module #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
interduo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improvements for voip module #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
051a9a9
improvement: add required html attribute when field must filled out b…
interduo Nov 15, 2025
7c27d2e
bugfix: don't show voip passwords when user has 'hide_voip_passwords'…
interduo Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions templates/default/voipaccount/voipaccountaddbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
{trans("Login:")}
</td>
<td>
<input type="text" id="voip-login" name="voipaccountdata[login]" value="{$voipaccountdata.login}" maxlength="32" size="20" {tip text="Enter VoIP account login" trigger="login" bold=1}>
<input type="text" id="voip-login" name="voipaccountdata[login]" value="{$voipaccountdata.login}" maxlength="32" size="20" {tip text="Enter VoIP account login" trigger="login" bold=1} required>
</td>
</tr>
{/block}
Expand All @@ -84,7 +84,7 @@
{trans("Password:")}
</td>
<td>
<input type="{if ConfigHelper::checkPrivilege('hide_voip_passwords')}password{else}text{/if}" name="voipaccountdata[passwd]" value="{$voipaccountdata.passwd}" {tip text="Enter password" trigger="passwd"}>
<input type="{if ConfigHelper::checkPrivilege('hide_voip_passwords')}password{else}text{/if}" name="voipaccountdata[passwd]" value="{$voipaccountdata.passwd}" {tip text="Enter password" trigger="passwd"} required>
<a href="#" id="genpasswd" {tip text="Click to generate random password"}>&raquo;&raquo;&raquo;</a>
</td>
</tr>
Expand All @@ -102,7 +102,7 @@
<input type="tel" name="voipaccountdata[numbers][0][phone]"
value="{$voipaccountdata.numbers[0].phone}"
placeholder="{trans("<!phone>number")}"
{tip class="phone-number" trigger="phone-number-0"}>
{tip class="phone-number" trigger="phone-number-0"} required>
<input type="search" name="voipaccountdata[numbers][0][info]"
value="{$voipaccountdata.numbers[0].info|default:""|escape}"
placeholder="{trans("description")}"
Expand All @@ -124,7 +124,7 @@
<td>
<input type="tel" name="voipaccountdata[numbers][{$k}][phone]"
value="{$v.phone}" placeholder="{trans("<!phone>number")}"
{tip trigger="phone-number-{$k}"}>
{tip trigger="phone-number-{$k}"} required>
<input type="search" name="voipaccountdata[numbers][{$k}][info]"
value="{$v.info|default:""|escape}"
class="phone-info" placeholder="{trans("description")}"
Expand Down Expand Up @@ -340,7 +340,8 @@
$('#add_number').on('click', function () {
var table = $('#phone_numbers_table');
var i = table.find('[type="tel"]').length;
var phone_number_input = '<input type="tel" name="voipaccountdata[numbers][' + i +'][phone]" class="phone-number" placeholder="{trans("<!phone>number")}" {tip trigger="phone-number"}>' +
var phone_number_input = '<input type="tel" name="voipaccountdata[numbers][' + i +'][phone]"' +
' class="phone-number" placeholder="{trans("<!phone>number")}" {tip trigger="phone-number"} required>' +
'<input type="search" name="voipaccountdata[numbers][' + i + '][info]" class="phone-info" placeholder="{trans("description")}" autocomplete="off" {tip trigger="phone-info"}>';
table.append('<tr class="row"><td>' + phone_number_input + '</td><td><div>' + pool_number_select + ' ' + remove_number + '</div></td></tr>');
var numbers = table.find('.remove-number');
Expand Down
8 changes: 5 additions & 3 deletions templates/default/voipaccount/voipaccounteditbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
{trans("Login:")}
</td>
<td>
<input type="text" name="voipaccountedit[login]" value="{$voipaccountinfo.login}" maxlength="32" size="30" {tip text="Enter VoIP account login" trigger="login" bold=1}>
<input type="text" name="voipaccountedit[login]" value="{$voipaccountinfo.login}" maxlength="32"
size="30"{tip text="Enter VoIP account login" trigger="login" bold=1} required>
({$voipaccountinfo.id|string_format:"%04d"})
</td>
</tr>
Expand Down Expand Up @@ -91,7 +92,7 @@
{trans("Password:")}
</td>
<td>
<input type="{if ConfigHelper::checkPrivilege('hide_voip_passwords')}password{else}text{/if}" name="voipaccountedit[passwd]" value="{$voipaccountinfo.passwd}" {tip text="Enter password" trigger="passwd"}>
<input type="{if ConfigHelper::checkPrivilege('hide_voip_passwords')}password{else}text{/if}" name="voipaccountedit[passwd]" value="{$voipaccountinfo.passwd}" {tip text="Enter password" trigger="passwd"} required>
<a href="#" id="genpasswd" {tip text="Click to generate random password"}>&raquo;&raquo;&raquo;</a>
</td>
</tr>
Expand Down Expand Up @@ -378,7 +379,8 @@
$('#add_number').on('click', function () {
var table = $('#phone_numbers_table');
var i = table.find('[type="tel"]').length;
var phone_number_input = '<input type="tel" name="voipaccountedit[numbers][' + i +'][phone]" class="phone-number" placeholder="{trans("<!phone>number")}" {tip trigger="phone-number"}>' +
var phone_number_input = '<input type="tel" name="voipaccountedit[numbers][' + i +'][phone]"' +
' class="phone-number" placeholder="{trans("<!phone>number")}" {tip trigger="phone-number"} required>' +
'<input type="search" name="voipaccountedit[numbers][' + i + '][info]" class="phone-info" placeholder="{trans("description")}" autocomplete="off" {tip trigger="phone-info"}>';
table.append('<tr class="row"><td>' + phone_number_input + '</td><td><div>' + pool_number_select + ' ' + remove_number + '</div></td></tr>');
var numbers = table.find('.remove-number');
Expand Down
2 changes: 1 addition & 1 deletion templates/default/voipaccount/voipaccountinfobox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
{trans("Password:")}
</td>
<td class="nobr">
{if ConfigHelper::checkPrivilege('hide_voip_passwords')}{'*'|str_repeat:8}{else}{$voipaccountinfo.passwd}{/if}
{if !ConfigHelper::checkConfig('privileges.hide_voip_passwords')}{$voipaccountinfo.passwd}{else}{'*'|str_repeat:8}{/if}
</td>
</tr>
{/block}
Expand Down
2 changes: 1 addition & 1 deletion templates/default/voipaccount/voipaccountlist.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ <h1>{$layout.pagetitle}</h1>
{/foreach}
</td>
<td onClick="return self.location.href = '?m=voipaccountinfo&amp;id={$voipaccountlist[voipaccountlist].id}';" valign="top" nowrap>
{if ConfigHelper::checkPrivilege('hide_voip_passwords')}{'*'|str_repeat:8}{else}{$voipaccountlist[voipaccountlist].passwd}{/if}
{if !ConfigHelper::checkConfig('privileges.hide_voip_passwords')}{$voipaccountlist[voipaccountlist].passwd}{else}{'*'|str_repeat:8}{/if}
</td>
<td align="right" class="nobr">
<a href="?m=voipaccountbillinglist&amp;id={$voipaccountlist[voipaccountlist].id}">
Expand Down