Process pending_close_binds unconditionally in evpl_continue#38
Open
Process pending_close_binds unconditionally in evpl_continue#38
Conversation
Previously, binds pending close were only cleaned up when evpl_core_wait() returned 0 (no events). Under sustained load this condition may never be met, causing pending close binds to accumulate indefinitely and preventing connections from being fully torn down. Process pending_close_binds on every iteration regardless of whether events were returned.
benjarvis
force-pushed
the
fix/pending-close-binds
branch
from
18fb319 to
f0a9ab8
Compare
Member
Author
|
Going to let this one lie for a bit. I have doubts because the reason for this logic in the first place is that the verbs RDMA stack can return events for an RDMA QP even after it has been disconnected, so we need a deferment of the final teardown of the bind related structures to ensure that any events we might receive about them have been received. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evpl_core_wait()returned 0 (no events)pending_close_bindson every iteration ofevpl_continue()regardless of event count