Skip to content

Conversation

@shohei-shibata
Copy link
Contributor

As the title says, feature to delete a user account is created.

  • Created a button in user profile editor page.
  • Added a modal to re-confirm the intention to delete user account.
  • Added delete route to api/users/:user_id which will:
    • Unfollow any projects followed by the user
    • Deletes any owned projects
    • Deletes user account

In the process I also created a fakeApi function to simulate logged in state, for speeding things up when working in the react development server.

Copy link

@sfiquet sfiquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if my review will be very helpful, there's a lot I'm unfamiliar with, especially Redux. It seems generally fine.

There are a lot of console.log for debugging, is it an oversight or is there a reason for keeping them?

Also in my view the fake api should be part of a test suite rather than the standard code but I guess it will do for now. I'm just wondering if you managed to test with the actual api as well?

Finally I notice you commented out the App constructor in routes.js. I think the call to super is important for React classes although I can't remember the reason. Also the state will be undefined until we use setState, which might be ok, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants