Open
Conversation
When the windowed FIR filter order was selected manually, it decremented each design run.
Refactor the FIR filter calculations to use numtaps (N + 1) instead of N. This change ensures that the filter order is correctly applied across all relevant methods.
The current implementation lead to exceptions and error prints when a high pass or band stop filter was designed. I'd say the order must be even for a filter to pass through the nyquist frequency. Example: A moving average filter with a tap length of 2 (order == 1) will block the nyquist frequency; A moving average filter with a tap length of 3 (order == 2) will pass the nyquist frequency. I'd assume that's also true for for windowed fir filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the windowed FIR filter order was selected manually, it decremented each design run.