Update mail-listener2 with changes from another forks #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set mime dependency version to ^1.0.0 because mime 2.0.0 package breaks the API
Update readme to describe what changes are included and be in line with the name of the new library and new features.
uapasha
reviewed
Nov 21, 2017
uapasha
left a comment
uapasha
left a comment
There was a problem hiding this comment.
Thanks a lot for your work! I hope it would be merged soon
| }, function(err){ | ||
| if( err ) { | ||
| }, function (err) { | ||
| console.log('all process'); |
| "name": "mail-listener2", | ||
| "version": "0.3.1", | ||
| "description": "Mail listener library for node.js. Get notification when new email arrived.", | ||
| "name": "mail-listener2-updated", |
| "url": "http://chiragjain.tumblr.com" | ||
| "name": "Daniel Pérez", | ||
| "email": "dapanas@gmail.com", | ||
| "url": "http://blogcito.info" |
| * Add a restart function to reconnect to imap server | ||
| * Enhanced logging for the new features | ||
| * Pass email object to attachment event | ||
| * Update mime dependency version to ^1.0.0 because mime 2.0.0 package break the API |
| ```javascript | ||
|
|
||
| var MailListener = require("mail-listener2"); | ||
| var MailListener = require("mail-listener2-updated"); |
| this.imap.removeAllListeners('mail'); | ||
| this.imap.removeAllListeners('update'); | ||
|
|
||
| console.log('calling imap connect'); |
There was a problem hiding this comment.
these two consoles probably can be removed
Author
Author
|
Closed and replaced by #74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes and improvements from another forks.
The changes are:
Every commit was made by me giving the right credit to the original authors.