Google Street View comparison support #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds Google Street View integration as a new comparison mode, allowing users to compare historical images with current Street View panoramas. It also updates the copyright year from 2025 to 2026 and introduces a configuration system for managing API keys.
Key Changes:
- Introduces Street View as an alternative comparison mode alongside camera-based comparisons
- Adds API key management through Xcode configuration files with validation
- Refactors comparison state from camera-specific naming to more generic capture terminology
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Rewind/Model/StreetViewFactory.swift | Creates WKWebView instances for displaying Google Street View with embedded HTML/CSS |
| Rewind/Secrets.swift | Manages Google Maps API key retrieval and validates configuration at launch |
| Rewind/Network/Request.swift | Adds Street View availability check via Google Maps API |
| Rewind/Model/ComparisonModel.swift | Refactors to support both camera and Street View capture modes |
| Rewind/Model/ImageDetailsModel.swift | Adds Street View comparison button alongside existing camera comparison |
| Rewind/View/ImageDetailsView.swift | Updates UI to display both comparison options with appropriate transitions |
| Rewind/View/ComparisonView.swift | Renames cameraState to captureState for mode-agnostic terminology |
| Rewind/Localizable.xcstrings | Adds translations for Street View features and updates year to 2026 |
| Config/Secrets.xcconfig.example | Provides template for API key configuration |
| README.md | Documents setup instructions for Google Maps API key |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rewind/Localizable.xcstrings
Outdated
| } | ||
| }, | ||
| "Google Street View Unavailable": { | ||
| "comment": "error alert tltle", |
There was a problem hiding this comment.
The comment "tltle" contains a typo. It should be "title".
Suggested change
| "comment": "error alert tltle", | |
| "comment": "error alert title", |
Rewind/Model/StreetViewFactory.swift
Outdated
| inset: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| min-width: 50px; // if size is 0x0, pov breaks |
There was a problem hiding this comment.
CSS comments in inline styles should use /* */ syntax, not //. The line comment syntax is not valid in CSS and may cause rendering issues.
Suggested change
| min-width: 50px; // if size is 0x0, pov breaks | |
| min-width: 50px; /* if size is 0x0, pov breaks */ |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.