Open
Conversation
buffrr
reviewed
Jun 9, 2022
Comment on lines
+146
to
+147
| if (res.code === codes.SERVFAIL) { | ||
| rc.bogus = true; |
Contributor
There was a problem hiding this comment.
What's the reason for setting bogus here? SERVFAIL doesn't necessarily mean bogus it could happen for many many reasons. It seems that the code path throws anyway if response code is something other than NOERROR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35 and maybe even #28 (for second part, doesn't check
cd).Changes:
bogusflag toResolveContextand set it when verification breaksdnssec-failed.organdrhybar.cz(taken from https://www.internetsociety.org/resources/deploy360/2013/dnssec-test-sites/)Also fixes tests (I can split it into a separate PR if needed):
iis.seis no longer weak, changed to falsemail.google.comdoesn't have a CNAME, so replaced it withonedrive.live.comtest/data/with latest from https://www.internic.net/domain/root.zonecom.