pkg: update deps, ci versions and linter.

.github/workflows/unit-test.yml

@@ -12,11 +12,11 @@ jobs:
 
     strategy:
       matrix:
-        node_version: [10.x, 12.x, 14.x]
+        node_version: [16.x, 18.x, 20.x, 24.x]
 
     steps:
       - name: Checkout Unbound
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           repository: nlnetlabs/unbound
           path: ub
@@ -29,10 +29,10 @@ jobs:
              sudo ldconfig
 
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Setup
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
 
       - name: Install
         run: npm install

.npmignore

@@ -15,3 +15,4 @@ package-lock.json
 test/
 webpack.*.js
 yarn.lock
+eslint.config.cjs

bin/bns-keygen

@@ -68,6 +68,7 @@ for (let i = 2; i < process.argv.length; i++) {
     }
 
     case '-f': {
+      // eslint-disable-next-line no-prototype-builtins
       if (!keyFlags.hasOwnProperty(next))
         throw new Error('Unknown flag.');
 

eslint.config.cjs

@@ -0,0 +1,50 @@
+'use strict';
+
+const rc = require('bslintrc');
+
+module.exports = [
+  rc.configs.recommended,
+  rc.configs.bcoin,
+  {
+    languageOptions: {
+      globals: {
+        ...rc.globals.node
+      },
+      ecmaVersion: 'latest'
+    }
+  },
+  {
+    files: [
+      'bin/bns-keygen',
+      'bin/bns-prove',
+      'bin/dig.js',
+      'bin/dig2json',
+      'bin/json2dig',
+      'bin/json2rr',
+      'bin/json2zone',
+      'bin/named.js',
+      'bin/read.js',
+      'bin/rr2json',
+      'bin/whois.js',
+      'bin/zone2json',
+      '**/*.js',
+      '*.js'
+    ],
+    languageOptions: {
+      sourceType: 'commonjs'
+    }
+  },
+  {
+    files: ['test/{,**/}*.{js,cjs,mjs}'],
+    languageOptions: {
+      globals: {
+        ...rc.globals.mocha,
+        register: 'readable'
+      }
+    },
+    rules: {
+      'max-len': 'off',
+      'prefer-arrow-callback': 'off'
+    }
+  }
+];

lib/wire.js

@@ -272,63 +272,63 @@ class Message extends Struct {
   }
 
   set qr(value) {
-    return this.setFlag(flags.QR, value);
+    this.setFlag(flags.QR, value);
   }
 
   get aa() {
     return this.getFlag(flags.AA);
   }
 
   set aa(value) {
-    return this.setFlag(flags.AA, value);
+    this.setFlag(flags.AA, value);
   }
 
   get tc() {
     return this.getFlag(flags.TC);
   }
 
   set tc(value) {
-    return this.setFlag(flags.TC, value);
+    this.setFlag(flags.TC, value);
   }
 
   get rd() {
     return this.getFlag(flags.RD);
   }
 
   set rd(value) {
-    return this.setFlag(flags.RD, value);
+    this.setFlag(flags.RD, value);
   }
 
   get ra() {
     return this.getFlag(flags.RA);
   }
 
   set ra(value) {
-    return this.setFlag(flags.RA, value);
+    this.setFlag(flags.RA, value);
   }
 
   get z() {
     return this.getFlag(flags.Z);
   }
 
   set z(value) {
-    return this.setFlag(flags.Z, value);
+    this.setFlag(flags.Z, value);
   }
 
   get ad() {
     return this.getFlag(flags.AD);
   }
 
   set ad(value) {
-    return this.setFlag(flags.AD, value);
+    this.setFlag(flags.AD, value);
   }
 
   get cd() {
     return this.getFlag(flags.CD);
   }
 
   set cd(value) {
-    return this.setFlag(flags.CD, value);
+    this.setFlag(flags.CD, value);
   }
 
   get qd() {
@@ -1447,7 +1447,7 @@ class EDNS extends Struct {
   }
 
   set dnssec(value) {
-    return this.setFlag(eflags.DO, value);
+    this.setFlag(eflags.DO, value);
   }
 
   set(code, option) {