-
Notifications
You must be signed in to change notification settings - Fork 0
Add dmffs config directory mounting at /configs/ #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
JohnAmadis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot zapisz to sobie gdzies w instrukcjach na przyszłość - nie używamy snprintf tylko funkcji z DMOD SAL
src/main.c
Outdated
| @@ -1,5 +1,6 @@ | |||
| #define DMOD_ENABLE_REGISTRATION | |||
| #include <string.h> | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
żadnego stdio!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9716f7d - removed stdio.h include
src/main.c
Outdated
|
|
||
| // Mount the dmffs filesystem at /configs/ | ||
| char mount_opts[128]; | ||
| snprintf(mount_opts, sizeof(mount_opts), "addr=0x%X,size=%u", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dmod_SnPrintf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9716f7d - replaced snprintf with Dmod_SnPrintf
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Understood - will use DMOD SAL functions (like Dmod_SnPrintf) instead of standard C library functions going forward |
Plan: Add Configuration Directory Mounting with dmffs
Understanding:
/configs/Implementation Steps:
scripts/romfs.cmakescript to:DMBOOT_CONFIG_DIRcmake variablemake_dmffstool to create filesystem image from the config directoryCMakeLists.txtto:DMBOOT_CONFIG_DIRas a cmake cache variablesrc/main.cto:/configs/inmount_embedded_filesystems()Summary
Successfully implemented configuration directory mounting using dmffs with DMOD SAL functions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.