Add test-path handler to cChocoPackageInstall in case of missing ChocoInstalled.xml#177
Add test-path handler to cChocoPackageInstall in case of missing ChocoInstalled.xml#177BCOps wants to merge 3 commits intochocolatey:developmentfrom
Conversation
|
Appveyor tests are showing as passing |
corbob
left a comment
There was a problem hiding this comment.
In general this code looks good. I would like to potentially see the commits updated to follow the Chocolatey guidelines, but we don't currently have anything on this repository to indicate the style and such, so for now I'll leave that.
I would however prefer to see some pester tests that test this issue if possible. However, it would be good to look at Pester 5 tests as #163 is adding that support. If you wanted to take a look at adding some after that is merged it'd be appreciated.
|
I just had a bit of a perusal over #103. If I understand this PR correctly, I suspect it took inspiration from that PR? Instead of the |
|
Is there any news about this Pull Request ? Is it gonna be merged ? |
Description Of Changes
cChocoPackageInstallGet-ChocoInstalledPackagehas been updated to test for the presence ofChocoInstalled.xmlbefore trying to delete it when purge is set to true, avoiding a breaking error if it is not located.Motivation and Context
Fixes #160
Testing
remove-itemwas skipped, and module run completed successfully.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #160