add tests asserting on types of that callback function receives#70
Merged
chodorowicz merged 1 commit intomainfrom Apr 4, 2026
Merged
add tests asserting on types of that callback function receives#70chodorowicz merged 1 commit intomainfrom
chodorowicz merged 1 commit intomainfrom
Conversation
# Conflicts: # src/index.test-d.ts
urbanfly
reviewed
Apr 6, 2026
| callback: (data: Promise<number>) => { | ||
| expectType<Promise<number>>(data); | ||
| }, | ||
| }); |
Contributor
There was a problem hiding this comment.
Now the declared type of the return value will be () => Promise<Promise<number>> which is not really a valid type.
Extend it a bit:
const fn = debounce(() => Promise.resolve(42), 100, {
callback: (data: Promise<number>) => {
expectType<Promise<number>>(data);
},
});
const result = await fn();
// result === 42
// the function type claims that it will be a Promise<number>, which is impossible
Contributor
There was a problem hiding this comment.
I now realize that you understand the point I was making above - and I didn't get your point about the callback option. This PR, combined with #68 should be a good combo.
urbanfly
added a commit
to urbanfly/ts-debounce
that referenced
this pull request
Apr 6, 2026
urbanfly
added a commit
to urbanfly/ts-debounce
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a test that the asserts on existing behavior of callback functions